Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all test failed plugins from the README #183

Open
10 of 14 tasks
smorimoto opened this issue Jan 25, 2020 · 40 comments
Open
10 of 14 tasks

Remove all test failed plugins from the README #183

smorimoto opened this issue Jan 25, 2020 · 40 comments

Comments

@smorimoto
Copy link
Member

smorimoto commented Jan 25, 2020

We are currently considering removing all test failed plugins from the README. Do you have the bandwidth to fix so that the test runs correctly again. Whether you have bandwidth or not, we recently started a collaborative, community-driven project called asdf-community for long-term maintenance of asdf plugins, so consider moving your plugins here.
https://github.com/asdf-community/.github

I'm tagging all the authors of the related plugin (in no particular order), but I'd like to hear everyone's opinions.

@smorimoto
Copy link
Member Author

CC: @blimmer (Ibotta/asdf-brig)

@smorimoto
Copy link
Member Author

CC: @nickveys, @gabecook (code-lever/asdf-rust)

@smorimoto
Copy link
Member Author

Of course, I can help you run the test correctly again.

@sylph01
Copy link

sylph01 commented Jan 25, 2020

I do recognize that there are issues for newer versions of mongodb, but its fix is not trivial, and I cannot work on fixing it right away. As such, please remove asdf-mongodb for now, and I will contact you again after fixing it.

@smorimoto
Copy link
Member Author

@sylph01 OK. I'm looking forward to your contact.

@odarriba
Copy link

I currently don't have bandwidth to maintain asdf-php in any of the ways I would like to (new versions, optimisations, PHP extensions or fixing the tests), so I would agree to transfer it to this community if it starts moving and maintaining this kind of projects.

@smorimoto
Copy link
Member Author

@odarriba We already manage a lot of plugins, for example the Standard ML plugin has been transferred by the author. If you okay, I will send you an invitation to prepare for the transfer.

@odarriba
Copy link

@imbsky let's transfer it then!

@smorimoto
Copy link
Member Author

@odarriba Sent!

@marciogm
Copy link

hey @imbsky.
I'm willing to transfer the asdf-crystal as well, could you send a invitation?

@nickveys
Copy link

@imbsky Just got asdf-rust fixed up, all green! Thanks for the reminder.

@smorimoto
Copy link
Member Author

@marciogm Sent!

@smorimoto
Copy link
Member Author

@nickveys Thank you! Really quick work!

@smorimoto
Copy link
Member Author

I fixed the asdf-crystal's CI and dealt with all issues.

@blimmer
Copy link
Contributor

blimmer commented Jan 26, 2020

@imbsky it looks like there's some kind of issue with Travis CI's badge on that repo. The tests are actually passing, even though the badge says that they're not:

Screen Shot 2020-01-26 at 8 27 03 AM

I opened Ibotta/asdf-brig#8 to see if they can fix up the badge, as I no longer have maintainer abilities on that repo.

@smorimoto
Copy link
Member Author

Thank you for checking! Hmm, that's weird... We've created a great tool for GitHub Actions, so it might be a good idea to move to it. https://github.com/asdf-vm/actions

@blimmer
Copy link
Contributor

blimmer commented Jan 26, 2020

Sounds good. I opened Ibotta/asdf-brig#9 for them to consider, since I don't have maintainer privs anymore. Thanks!

@smorimoto
Copy link
Member Author

@blimmer Thank you again for your quick response!

@ndac-todoroki
Copy link
Contributor

@imbsky Sorry for being late, I've fixed asdf-v. Thanks for the reminder!

@smorimoto
Copy link
Member Author

@ndac-todoroki Great!

@michaelstephens
Copy link
Contributor

As a whole I think asdf community is a great thing, I'd be happy to pass asdf-elasticsearch off to that

@smorimoto
Copy link
Member Author

@mikestephens I sent you an invitation!

@mtatheonly
Copy link

@imbsky Fixed the asdf-scala plugin =)

@smorimoto
Copy link
Member Author

@mtatheonly Thank you!

@vic
Copy link
Contributor

vic commented Jan 31, 2020

Nice, I'll also try fixing mines this weekend and transfer them.

@smorimoto
Copy link
Member Author

Awesome! By the way, most plugins have been fixed by the author or community maintainer. Thanks to everyone who helped us.

@particledecay
Copy link
Contributor

Selection_762
This plugin was renamed to "Talos" per #151. Sorry... should have removed osctl. I can submit another PR to remove it.

@smorimoto
Copy link
Member Author

@particledecay All right!

@smorimoto
Copy link
Member Author

I just setup GitHub Actions on asdf-php in asdf-community/asdf-php#31!

@smorimoto
Copy link
Member Author

I also added CI setup to elasticsearch.

@richin13
Copy link
Contributor

richin13 commented Mar 9, 2020

Sorry for the late response, asdf-neovim is now green

@smorimoto
Copy link
Member Author

@richin13 No worries! Thank you!

@vic
Copy link
Contributor

vic commented Mar 10, 2020

asdf-graalvm is green again.

@smorimoto
Copy link
Member Author

Thanks!

@elementalvoid
Copy link
Contributor

elementalvoid commented May 14, 2020

Oh dang. I missed this one -- I can help out with asdf-brig (hey @blimmer!)

Since Ben was the only contributor no one @Ibotta got a notification of the issue he made for us. I've set myself as a watcher and will be fixing the build very soon.

@elementalvoid
Copy link
Contributor

asdf-brig has been fixed!

GitHub Actions Status

@smorimoto
Copy link
Member Author

Thanks!

@yozachar
Copy link
Contributor

I think, this can be automated..

@jthegedus
Copy link
Contributor

I don't want to remove plugins automatically. GitHub checks have intermittent failures more frequently than I enjoy.

I did update the CI so commits on the default branch tests all plugins and summarizes the information. For example:

 * Checking plugins/vendir [FAILED]
*	FAIL: Expected plugin CI badge SVG to be passing but it was not: https://github.com/vmware-tanzu/asdf-carvel/workflows/test-all/badge.svg
* Checking plugins/ytt [FAILED]
*	FAIL: Expected plugin CI badge SVG to be passing but it was not: https://github.com/vmware-tanzu/asdf-carvel/workflows/test-all/badge.svg

Plugins available: 638
Plugin build checks passed: 549
Plugin build checks failed: 89

source - https://github.com/asdf-vm/asdf-plugins/actions/runs/4751694153/jobs/8441129580

I think there are ways to further automate this and report to the authors that there are issues, whether by tagging them in a thread in this repo or by opening Issues in the plugin repos. However, I don't feel the effort is worth the reward.

Very few people seem to complain about plugins actually not working. It's only a few times a year that we replace unmaintained plugins with new forks. Although some of the repos here might not work, they give people a place to fork from and then we can update this repo with their new plugins.

This is a health check at best. It isn't, and shouldn't, be a tool for people to gauge plugin health, robustness or trust. I try to point this out as much in this repo's README, SECURITY file and core tool documentation site.

@yozachar
Copy link
Contributor

I agree, not removing plugins directly, instead automating the notification of failed builds, with a warning of grace time, say 3 to 6 months to fix the build. It's more of a maintenance status check, and yeah I also doubt if it's worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests