-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS refers to font not necessarily available on the system #651
Comments
Good observation. The default stylesheet is written with the assumption that those fonts will be loaded as web fonts. (See https://github.com/asciidoctor/asciidoctor-browser-extension/blob/main/app/css/themes/asciidoctor.css). And that's precisely what Asciidoctor's HTML converter does. As I understand it, however, a browser extension cannot load fonts directly from the web (or it can but we don't want it to?). If that's the case, then they should probably be bundled so that they can be loaded locally...at least by the default stylesheet. |
CSP policies, Google Chrome won't load Google Fonts because it's unsafe 🥲 We might want to use https://www.npmjs.com/package/@fontsource/noto-serif to make it easier to manage. |
The
asciidoctor.css
of the default theme useswhich renders in Times New Roman on systems that don't have Noto installed. Does it make sense to bundle up the fonts used in the themes?
The text was updated successfully, but these errors were encountered: