Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core\unstack] deprecate .discard #1870

Open
RickBarretto opened this issue Jan 29, 2025 · 2 comments · May be fixed by #1877
Open

[Core\unstack] deprecate .discard #1870

RickBarretto opened this issue Jan 29, 2025 · 2 comments · May be fixed by #1877
Assignees
@drkameleon @RickBarretto
Labels
→ Core enhancement New feature or request

Comments

@RickBarretto
Copy link
Collaborator

At A Glance

Since we have Core\discard, we don't need this attribute anymore. Attributes like this may be confusing, and inconsistent, since the function may or not may push values into the stack.

Old way

1 2 3
unstack.discard 1

New way

1 2 3
discard unstack 1
@RickBarretto RickBarretto added the enhancement New feature or request label Jan 29, 2025
@drkameleon
Copy link
Collaborator

I think that's a very valid suggestion.

Would you be open to do it? I think it should be rather straightforward. 😉

The only catch: make sure there are no tools/scripts using it (and if there are, adapt that as well ;-) )

AFAIK, the first thing that comes to my mind would be the REPL script. But, e.g. Grafito would be using it as well...

@RickBarretto
Copy link
Collaborator Author

Would you be open to do it?

Absolutely! 🙂

@RickBarretto RickBarretto self-assigned this Feb 4, 2025
This was referenced Feb 5, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drkameleon drkameleon

@RickBarretto RickBarretto

Labels
→ Core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core\unstack] Deprecate unstack.discard RickBarretto/arturo
2 participants
@drkameleon @RickBarretto