Skip to content

Commit 24774bd

Browse files
authored
fix(plugins-test): try harder for the version of versionNotSupportedPlugin to actually not be supported (spinnaker#1161)
Before this, an echo version >= 2.0.0 would cause versionNotSupportedPlugin to get used, causing tests to fail, and making it impossible to e.g. release echo.
1 parent a186b52 commit 24774bd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

echo-plugins-test/src/test/kotlin/com/netflix/spinnaker/echo/plugins/test/EchoPluginsFixture.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ class EchoPluginsFixture : PluginsTckFixture, EchoTestService() {
6565
plugins.mkdir()
6666
enabledPlugin = buildPlugin("com.netflix.echo.enabled.plugin", ">=1.0.0")
6767
disabledPlugin = buildPlugin("com.netflix.echo.disabled.plugin", ">=1.0.0")
68-
versionNotSupportedPlugin = buildPlugin("com.netflix.echo.version.not.supported.plugin", ">=2.0.0")
68+
// Make it very unlikely that the version of echo satisfies this requirement
69+
versionNotSupportedPlugin = buildPlugin("com.netflix.echo.version.not.supported.plugin", "=0.0.9")
6970
}
7071
}
7172

0 commit comments

Comments
 (0)