Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queue controller #323

Open
Sovietaced opened this issue Aug 8, 2024 · 2 comments
Open

Implement queue controller #323

Sovietaced opened this issue Aug 8, 2024 · 2 comments

Comments

@Sovietaced
Copy link
Contributor

The current queue controller does nothing. We tried to use it and realized it didn't work after looking at the source code.

func (r *QueueReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
	_ = log.FromContext(ctx)

	// TODO(user): your logic here

	return ctrl.Result{}, nil
}

FWIW, we will be implementing this in our fork and I can upstream the work.

@dave-gantenbein
Copy link
Member

Thanks @Sovietaced, we're looking forward to your contribution!

@dejanzele
Copy link
Member

Hi @Sovietaced,

Thanks for raising this issue!

The Queue controller is currently just a placeholder.

If you implement it in your fork, feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants