Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential accuracy issues due to loss of precision #2

Open
arlyon opened this issue Sep 3, 2020 · 0 comments
Open

Potential accuracy issues due to loss of precision #2

arlyon opened this issue Sep 3, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@arlyon
Copy link
Owner

arlyon commented Sep 3, 2020

The article here (http://extremelearning.com.au/an-improved-version-of-bridsons-algorithm-n-for-poisson-disc-sampling/) describes the use of some epsilon value seen here as a work around for floating point precision issues, by adding some small value to the radius when generating new points. I have enabled a lint to highlight locations where we lose precision thanks to clippy::cast_possible_truncation. Maybe by eliminating these we can also eliminate the epsilon?

It should be noted that this epsilon will probably cause the algorithm to perform strangely on small ranges / radii so as a workaround making it a function of the radius is probably a good mitigation.

@arlyon arlyon added the good first issue Good for newcomers label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant