Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): BGP add redistribute option under address_family_ipv4 #3928

Closed
1 task done
pvinci-arista opened this issue May 1, 2024 · 3 comments
Closed
1 task done
Labels
type: enhancement New feature or request

Comments

@pvinci-arista
Copy link
Contributor

Enhancement summary

The keys are available in other address families, but are missing for ipv4. The expectation was probably that users could set ipv4_unicast: true

router_bgp:
        bgp:
          default:
            ipv4_unicast: false
         address_family_ipv4:
           redistribute_routes:
             - source_protocol: connected
               route_map: RM-CONN_TO_BGP

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Connected networks in the default vrf should be advertised into bgp.

Describe the solution you would like

reuse the same keys from other address families.

router_bgp:
        bgp:
          default:
            ipv4_unicast: false
         address_family_ipv4:
           redistribute_routes:
             - source_protocol: connected
               route_map: RM-CONN_TO_BGP

In the alternative, implement either eos_cli: or structured_config: under address_family_ipv4:

Describe alternatives you have considered

This can be implemented today with the following keys

      eos_cli: |-
        router bgp 12345
          address-family ipv4
            redistribute connected route-map RM-CONN_TO_BGP

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@pvinci-arista pvinci-arista added the type: enhancement New feature or request label May 1, 2024
@ClausHolbechArista
Copy link
Contributor

This will be addressed by #3814. Please confirm.

@ClausHolbechArista
Copy link
Contributor

#3814 was merged. Please check and revert if this one can be closed or if we are still missing something.

@ClausHolbechArista
Copy link
Contributor

@pvinci-arista I will close this issue since I believe it has been addressed. Feel free to reopen if you do not agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants