New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow setting an array of filters (subjects) #35

Open

moltar opened this issue Sep 16, 2023 · 1 comment · May be fixed by #41

moltar commented Sep 16, 2023

Currently, it is only possible to set one filter per role.

aws-cdk-github-oidc/src/role.ts

Lines 163 to 166 in 53de62a

 StringLike: { 

 // Only allow specified subjects to assume this role 

 [`${GithubActionsIdentityProvider.issuer}:sub`]: subject, 

 },

However I believe it is possible to support an array of filters, like so:

      "Condition": {
        "ForAnyValue:StringLike": {
          "token.actions.githubusercontent.com:sub": [
            "repo:myorg/myrepo:ref:refs/heads/test-branch-1",
            "repo:myorg/myrepo:ref:refs/heads/test-branch-2"
          ]
        }

(not actually tested, source)

blimmer linked a pull request

that will close this issue

feat: support passing multiple trustedRepositories #41

Open

blimmer commented Nov 11, 2023

I opened #41 with a proposed API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment