New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[color-schemes] Wrong lightness of cards for light theme #72
Comments
@argyleink Does lightness of card in you demo expresses elevation? If so, in Material Design the lightness expresses elevation only for dark theme, the light theme uses shadows to express elevation. See this animation. So it would be really interesting to know how to calculate shadow parameters for the light theme using CSS (or JS). 🙏 |
the lightnesses are just "surfaces" and aren't trying to represent elevation. that sounds like a fun addition tho! my lightnesses arent ordered or follow a pattern because i made them more visually than i did in code. here's where everything is used, you can inspect how the surfaces and text colors played out in an example space. the 4th card also looks higher because it's "on top" of all the others due to DOM order. creates an illusion of higher depth. |
In both, dark and dim themes, the lightness of card 4 is higher than the lightness of card 3, the lightness of card 3 is higher than the lightness of card 2, the lightness of card 2 is higher than the lightness of card 1.
But in light theme for some reason the lightness of card 2 is higher than the lightness of card 3, the lightness of card 3 is higher than the lightness of card 1, the lightness of card 1 is higher than the lightness of card 4.
Why?
The text was updated successfully, but these errors were encountered: