Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing the RTL flip #48

Open
argyleink opened this issue Aug 11, 2021 · 6 comments
Open

consider removing the RTL flip #48

argyleink opened this issue Aug 11, 2021 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed switch

Comments

@argyleink
Copy link
Owner

Mohammed Ali Agha commented the change is understood but not needed as they've already adjusted

@argyleink argyleink added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers switch labels Aug 11, 2021
@benbender
Copy link
Contributor

benbender commented Aug 12, 2021

Basic question at the end: If people are used to broken designs/behaviour (which may be formally incorrect), should we fix it anyways? I'm unsure if there is a definitive answer in this case at all because it may be very depending on who you ask...

The same topic is discussed here https://www.youtube.com/watch?v=OHF2h1_fBCM and I'm quite unsure about this for myself - but would be interested in more input on this.

@argyleink
Copy link
Owner Author

great link and thoughts, thanks!

@X7md
Copy link

X7md commented Oct 24, 2022

any progress, to fix it?

@X7md
Copy link

X7md commented Oct 24, 2022

Sidenav don't support RTL
https://github.com/argyleink/gui-challenges/tree/main/sidenav

@argyleink
Copy link
Owner Author

not clear in this issue, but yeah, it's attached to the Switch component.

@Sboonny
Copy link

Sboonny commented Jan 14, 2023

I don't think there is a real issue here, and this can be closed. I have opened the switch component to fix it, but watching the video and interacting with the component in the local environment, you have taken the right approach.

aria-pressed= true state
showing aria-pressed

aria-pressed= false state
showing aria-pressed-false


aria-pressed= true on the iPhone

showing aria-pressed on iPhone

aria-pressed= false on the iPhone

showing aria-pressed-false on iPhone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed switch
Projects
None yet
Development

No branches or pull requests

4 participants