Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context field for notifications #2595

Open
TomaszKrzeminskiMA opened this issue Feb 16, 2023 · 3 comments · May be fixed by #3553
Open

Add context field for notifications #2595

TomaszKrzeminskiMA opened this issue Feb 16, 2023 · 3 comments · May be fixed by #3553
Labels
enhancement New feature or request no-issue-activity

Comments

@TomaszKrzeminskiMA
Copy link

Summary

Currently, only a limited number of fields can be used to template messages, which includes: rollout and recipient (https://argoproj.github.io/argo-rollouts/features/notifications/#templates).
I would like to use the context feature to define shared variables (https://argocd-notifications.readthedocs.io/en/stable/templates/#defining-user-defined-context)

Use Cases

Define some shared context between all notification templates by setting a top-level YAML document of key-value pairs, which can then be used within templates.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@TomaszKrzeminskiMA TomaszKrzeminskiMA added the enhancement New feature or request label Feb 16, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@soar
Copy link

soar commented Dec 10, 2023

It's even strange, because in the docs there are a lot of mentions for context usage:

screenshot

I even checked it twice, but it doesn't work.

@pshrm
Copy link

pshrm commented Feb 8, 2024

almost a year! still no progress.

@daftping daftping linked a pull request May 4, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add user-defined context to notifications daftping/argo-rollouts
3 participants
@soar @pshrm @TomaszKrzeminskiMA