Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade log level for messages around notifs for rollout lifecycle "...trigger '<EVENT>' is not configured" #3459

Open
meeech opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@meeech
Copy link
Contributor

meeech commented Mar 21, 2024

Summary

This concerns notifications around rollout lifecycle.

These messages are very noisy and dont feel like errors. they should be info (maybe warning?)

example message: time="2024-03-21T18:29:30Z" level=error msg="Failed to run trigger, trigger: on-scaling-replica-set, destination: {slack argo-rollouts-notifications}, namespace config: : trigger 'on-scaling-replica-set' is not configured"

even better would be fire once the first time and never again.

i want to do this work but first wanted to check if there is reason these are error level messages.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@meeech meeech added the enhancement New feature or request label Mar 21, 2024
@meeech meeech changed the title Downgrade log messages for "...trigger '<EVENT>' is not configured" Downgrade log level for messages around notifs for rollout lifecycle "...trigger '<EVENT>' is not configured" Mar 21, 2024
@zachaller
Copy link
Collaborator

zachaller commented Mar 21, 2024

Yea this is a bug, the fix will probably be in notification-engine and is related to the self service namespaced notification support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants