Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make secrets available for notification templates #3455

Open
eroznik opened this issue Mar 20, 2024 · 0 comments
Open

Make secrets available for notification templates #3455

eroznik opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@eroznik
Copy link
Contributor

eroznik commented Mar 20, 2024

Summary

I'd like to expose secret data in notification templates, this would have to be done here. I'd suggest we do it similar to what I did on ArgoCD and if needed, we can add a feature flag to include secrets just conditionally.

Use Cases

This was already done on ArgoCD and it is useful to trigger webhooks that require auth data in payloads.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@eroznik eroznik added the enhancement New feature or request label Mar 20, 2024
eroznik added a commit to eroznik/argo-rollouts that referenced this issue Mar 23, 2024
@eroznik
feat: expose secrets for notification templates (argoproj#3455)
07584df
zachaller pushed a commit that referenced this issue Mar 28, 2024
@eroznik
feat: expose secrets for notification templates (#3455) (#3466)
86a2df6 
* feat: expose secrets for notification templates

Signed-off-by: Etien Roznik <[email protected]>

* feat: expose secrets for notification templates

Signed-off-by: Etien Roznik <[email protected]>

---------

Signed-off-by: Etien Roznik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eroznik