Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetstreamExotic requiring secure connection (no opt-out) #2938

Open
diogobaeder opened this issue Dec 13, 2023 · 3 comments
Open

jetstreamExotic requiring secure connection (no opt-out) #2938

diogobaeder opened this issue Dec 13, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers pinned

Comments

@diogobaeder
Copy link

Describe the bug
Argo Events requires secure connection to use jetstreamExotic, but it shouldn't - not because secure connections shouldn't be used, but because there are cases when they're not required, like on dev environments (which is my case) and when running inside a service mesh that provides mTLS.

To Reproduce
Steps to reproduce the behavior:

  1. Run a NATS server with JetStream enabled, but without any secure connections enabled
  2. Spin up Argo Events
  3. Create an EventBus pointing to the NATS server, using jetstreamExotic
  4. Check the logs

Expected behavior
I should be able to connect the EventBus with the external NATS server without problems.

Screenshots
(None)

Environment (please complete the following information):

  • Kubernetes: v1.27.3
  • Argo: v3.5.1
  • Argo Events: latest+ec96ecd

Additional context
Here's where the secure connection is forced: https://github.com/argoproj/argo-events/blob/master/eventbus/jetstream/base/jetstream.go#L70


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@diogobaeder diogobaeder added the bug Something isn't working label Dec 13, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had
any activity in the last 60 days. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 12, 2024
@whynowy whynowy added pinned good first issue Good for newcomers and removed stale labels Feb 12, 2024
@ondrejmo
Copy link

Is there any plan to fix this? I am asking mostly because it seems to me that the argo-events is no longer being actively developed and it would be good to know if I should search for replacement. Thank you

@diogobaeder
Copy link
Author

Yeah, it looks like it's not very active at the moment. I don't know if this has anything to do with Octopus buying Codefresh, but I sure hope the project gets some love again.

For the time being, though, I was forced to stop using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers pinned
Projects
None yet
Development

No branches or pull requests

3 participants