Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to edit http repo credentials from ArgoCD UI #22065

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: Unable to edit http repo credentials from ArgoCD UI #22065

wants to merge 7 commits into from
+20 −17

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Feb 27, 2025 •
edited
Loading

Fixes: #22246
This PR fixes the issue where HTTP repository credentials cannot be edited from the ArgoCD UI. Previously, only HTTPS repositories were clickable and editable in the UI. Now both HTTP and HTTPS repositories can be edited.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@aali309 aali309 requested a review from a team as a code owner February 27, 2025 18:53
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Feb 27, 2025 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@aali309
Copy link
Contributor Author

aali309 commented Feb 27, 2025 •
edited
Loading

Screenshot 2025-02-27 at 2 06 33 PM

Screenshot 2025-02-27 at 2 00 37 PM

keithchong
keithchong reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to add http as a new Connection method, as a separate change, when one wants to create a new repo connection? Or, should the current https be named to http(s), or http/https, or.....?

@aali309
Copy link
Contributor Author

aali309 commented Mar 3, 2025

Do we have to add http as a new Connection method, as a separate change, when one wants to create a new repo connection? Or, should the current https be named to http(s), or http/https, or.....?

The existing HTTPS connection method already handles both HTTP and HTTPS protocols under the hood - we just needed to fix the validation and UI display. Renaming it to HTTP/HTTPS would make sense to better reflect this capability.

@aali309 aali309 force-pushed the http branch 2 times, most recently from 1a7da01 to 8ef3738 Compare March 4, 2025 00:57
keithchong
keithchong requested changes Mar 5, 2025
View reviewed changes
ui/src/app/settings/components/repos-list/repos-list.tsx Outdated
@@ -355,7 +358,14 @@ export class ReposList extends React.Component<
<div className='columns small-4'>
<Tooltip content={repo.repo}>
<span>
<Repo url={repo.repo} />
<a
Copy link
Contributor

@keithchong keithchong Mar 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change? The Repo component should take care of this? However, the Repo component probably needs to be updated to include onClick={e => e.stopPropagation()}

ui/src/app/settings/components/repos-list/repos-list.tsx
@@ -125,7 +125,7 @@ interface NewGoogleCloudSourceRepoCredsParams {

export enum ConnectionMethod {
SSH = 'via SSH',
HTTPS = 'via HTTPS',
HTTPS = 'via HTTP/HTTPS',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-05 at 9 31 00 AM

This looks ok...

@aali309 aali309 requested a review from keithchong March 6, 2025 19:09
keithchong
keithchong requested changes Mar 6, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome requested changes

@keithchong keithchong keithchong requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to edit HTTP repo credentials from ArgoCD UI
3 participants
@aali309 @todaywasawesome @keithchong