Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e tests once other minimal checks ends successfully #22156

Open
jsolana opened this issue Mar 4, 2025 · 6 comments
Open

Run e2e tests once other minimal checks ends successfully #22156

jsolana opened this issue Mar 4, 2025 · 6 comments
Assignees
Labels
component:test Test requests (e2e or unit) enhancement New feature or request

Comments

@jsolana
Copy link
Contributor

jsolana commented Mar 4, 2025

Summary

e2e tests are expensive, lasting 30 - 35 min to be executed.

Does it make sense to run resource-intensive e2e tests before completing basic checks like ensuring there are no schema changes? Example

Motivation

Just wondering if make sense to "spend resources" running e2e tests with a pipeline that fails
Image

Proposal

Instead to run e2e in parallel from the beginning, lets waitfor the minimal unit test and checks as linter, changes with codegen etc,. before start to avoid run those pipelines if one of this steps fail:

  • Lint Go Code
  • Check changes to generated code
  • Build, test & lint UI code
@jsolana jsolana added the enhancement New feature or request label Mar 4, 2025
@sivchari
Copy link
Contributor

sivchari commented Mar 4, 2025

May I work on it ?

@andrii-korotkov-verkada
Copy link
Contributor

@sivchari, sure, you don't have to ask permissions :)

@jsolana
Copy link
Contributor Author

jsolana commented Mar 7, 2025

May I work on it ?

Hi during next days Im gonna have time to dedicate to this issue. Do you have any progress?

@andrii-korotkov-verkada
Copy link
Contributor

It's been only 3 days ago, I suggest to pick some other issue for now and come back to this a couple of weeks later if there's no progress.

@jsolana
Copy link
Contributor Author

jsolana commented Mar 7, 2025

It's been only 3 days ago, I suggest to pick some other issue for now and come back to this a couple of weeks later if there's no progress.

Sure, I was just asking because both tasks were assigned to the same person shortly after I created them, and I was wondering if it might be too much for one person at once.

I understand if work has already started on one, but if not, I was just asking in case I could lend a hand.

Thanks!

@crenshaw-dev
Copy link
Member

Instead of blocking e2e tests on faster checks, I'd cancel e2e tests if another check fails. That way we free up runners, but we don't delay e2e another ~5min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test requests (e2e or unit) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants