Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Policy/policy.open-cluster-management.io stuck in progressing status when no clusters match the policy (#21296) #21297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Policy/policy.open-cluster-management.io stuck in progressing status when no clusters match the policy (#21296) #21297

wants to merge 1 commit into from
+130 −1

Conversation

mbaldessari
Copy link

When a policy does not apply to a cluster because the placementrule matches no cluster at all then the status will look like the following:

status:
  placement:
  - placementBinding: group-one-placement-binding
    placementRule: group-one-placement

Without this change the above will show up as progressing even though there is really nothing to progress.

Let's take care of this case by returning healthy when there is no compliant field but the array under placement is non-zero, which means that its placement resolution has happened and there is nothing to do.

Fixes: #21296

Ideally this should be backported to release-2.13 (only)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [n/a] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [no] Does this PR require documentation updates?
  • [n/a] I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • [n/a] My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@mbaldessari
fix: Policy/policy.open-cluster-management.io stuck in progressing st…
b1f6b7a 
…atus when no clusters match the policy (argoproj#21296)

When a policy does not apply to a cluster because the placementrule
matches no cluster at all then the status will look like the following:

    status:
      placement:
      - placementBinding: group-one-placement-binding
        placementRule: group-one-placement

Without this change the above will show up as progressing even though
there is really nothing to progress.

Let's take care of this case by returning healthy when there is no
compliant field but the array under placement is non-zero, which means
that its placement resolution has happened and there is nothing to do.

Fixes: argoproj#21296
Signed-off-by: Michele Baldessari <[email protected]>
@mbaldessari mbaldessari requested a review from a team as a code owner December 23, 2024 09:58
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 23, 2024 •
edited
Loading

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-perafm.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-perafm.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (f15e1bc) to head (b1f6b7a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21297      +/-   ##
==========================================
- Coverage   55.23%   53.29%   -1.94%     
==========================================
  Files         337      337              
  Lines       57055    57055              
==========================================
- Hits        31515    30409    -1106     
- Misses      22847    24001    +1154     
+ Partials     2693     2645      -48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy/policy.open-cluster-management.io is in Progressing state even though there is nothing to do
1 participant
@mbaldessari