-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.8.0 update will no longer support wild card health checks #998
Comments
Hi @andreabjork, thanks for bringing this to attention.
If the new keys don't support your use-case, you can workaround it in the operator by adding old customizations into spec:
extraConfig:
resource.customizations: |
"*.aws.crossplane.io/*":
health.lua: |
... As for your feature request, what you've highlighted regarding lack of support for wildcards in new keys is true. However, it has to be supported in ArgoCD first before operator can use it. Can you create an issue in https://github.com/argoproj/argo-cd to discuss about wildcard support for new resource keys added in argoproj/argo-cd#6060? |
Is your feature request related to a problem? Please describe.
In ArgoCD 2.6.0 release, support for wildcard health checks was added under the
resource.customization
config map field:argoproj/argo-cd#10885
https://github.com/argoproj/argo-cd/releases/tag/v2.6.0
The config map section in question looks as follows:
Your documentation states:
In order to use
resourceHealthChecks
to try to achieve the wild card match, we would need to do something likeHowever, the
resourceHealthChecks
field mapsgroup
andkind
as follows:so attempting wild card matches in this way will naturally result in reconciler error:
Describe the solution you'd like
I would expect one of two solutions to be taken:
resourceCustomization
field in ArgoCD CRD, orresourceHealthChecks
toresource.customizations.health
differently such that wildcard can still be used in the manner ofgroup: *.aws.crossplane.io, kind: *
.This should be easy to achieve, by avoiding
snake_case
mapping and quoting the input instead, such that any input with "*" is still YAML compliant.Describe alternatives you've considered
An alternative would be to add customized key for defining wild card health checks, such as allowing the spec:
The text was updated successfully, but these errors were encountered: