Skip to content

Commit 7cd0908

Browse files
committed
Update changelogs
1 parent bd6e7d2 commit 7cd0908

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ All notable changes to this project will be documented in this file.
1010
### Breaking Changed
1111

1212
### Changed
13-
- Berry make Leds animate calls reentrant
13+
- Berry make Leds animate calls reentrant (#22643)
14+
- SSL clean up remnants of old fingerprint algorithm (#22645)
1415

1516
### Fixed
1617
- ESP32 rules operation priority regression from v13.3.0.4 (#22636)

RELEASENOTES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ The latter links can be used for OTA upgrades too like ``OtaUrl https://ota.tasm
121121
### Breaking Changed
122122

123123
### Changed
124+
- Berry make Leds animate calls reentrant [#22643](https://github.com/arendst/Tasmota/issues/22643)
125+
- SSL clean up remnants of old fingerprint algorithm (#22645)[#22645](https://github.com/arendst/Tasmota/issues/22645)
124126

125127
### Fixed
126128
- GUI display power button regression from v14.3.0.5 [#15788](https://github.com/arendst/Tasmota/issues/15788)

tasmota/tasmota_xdrv_driver/xdrv_67_mcp23xxx.ino

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ void MCP23xModuleInit(void) {
628628
#endif
629629
while ((Mcp23x.max_devices < MCP23XXX_MAX_DEVICES) && PinUsed(GPIO_MCP23SXX_CS, Mcp23x.max_devices)) {
630630
Mcp23x.chip = Mcp23x.max_devices;
631-
uint32_t pin_int = (Mcp23x.iocon.ODR) ? 0 : Mcp23x.chip; // INT pins are open-drain outputs and supposedly connected together to one GPIO
631+
uint32_t pin_int = (Mcp23x.iocon.ODR) ? 0 : Mcp23x.chip; // INT ODR pins are open-drain outputs and supposedly connected together to one GPIO
632632
Mcp23x.device[Mcp23x.chip].pin_int = (PinUsed(GPIO_MCP23XXX_INT, pin_int)) ? Pin(GPIO_MCP23XXX_INT, pin_int) : -1;
633633
Mcp23x.device[Mcp23x.chip].pin_cs = Pin(GPIO_MCP23SXX_CS, Mcp23x.max_devices);
634634
digitalWrite(Mcp23x.device[Mcp23x.chip].pin_cs, 1);
@@ -719,6 +719,8 @@ void MCP23xModuleInit(void) {
719719
return;
720720
}
721721

722+
AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("MCP: INT open-drain %d"), Mcp23x.iocon.ODR);
723+
722724
Mcp23x.relay_offset = TasmotaGlobal.devices_present;
723725
Mcp23x.relay_max -= UpdateDevicesPresent(Mcp23x.relay_max);
724726

@@ -774,7 +776,8 @@ void MCP23xInit(void) {
774776
gpio = MCP23xRead16(MCP23X17_GPIOA); // Clear MCP23x17 interrupt
775777
}
776778
if (Mcp23x.iocon.ODR && Mcp23x.chip) { continue; }
777-
pinMode(Mcp23x.device[Mcp23x.chip].pin_int, (Mcp23x.iocon.ODR) ? INPUT_PULLUP : INPUT);
779+
// pinMode(Mcp23x.device[Mcp23x.chip].pin_int, (Mcp23x.iocon.ODR) ? INPUT_PULLUP : INPUT);
780+
pinMode(Mcp23x.device[Mcp23x.chip].pin_int, INPUT_PULLUP);
778781
attachInterrupt(Mcp23x.device[Mcp23x.chip].pin_int, MCP23xInputIsr, (Mcp23x.iocon.ODR) ? FALLING : CHANGE);
779782
}
780783
}

0 commit comments

Comments
 (0)