PR with only one commit rule is necessary?

[sivaprasadreddy]

Hi,
I am facing difficulty with "PR should have only one commit" rule.
I know there is documentation, but it feels difficult for me.

While merging a PR, GitHub gives option to Squash and Merge. So, can't we remove the "PR should have only one commit" rule to make it easy for the contributors?

[ThomasVitale]

@sivaprasadreddy thanks for raising this. I acknowledge that it can be tricky and it's an unnecessary barrier for contributors. I'll rework the docs to mention that it's recommended to squash commits, but that it's fine to let the maintainers do that when merging.

Would that work?

[sivaprasadreddy]

@ThomasVitale That would be great. Looking forward to contributing more.

[ThomasVitale]

@sivaprasadreddy I have updated the guidelines removing the requirement for rebase/squash and signature. I hope that makes the contribution process more straightforward. Any feedback on the new process would be highly appreciated, thanks so much!

https://github.com/arconia-io/arconia/blob/main/CONTRIBUTING.md

[sivaprasadreddy]

@ThomasVitale The updated guidelines is really helpful and the simplified process helps more people to contribute. Thank you.

[ThomasVitale]

Thank you!