Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual partitioning is unusable (and dangerous) with a larger font #2971

Open
ehaynes99 opened this issue Nov 30, 2024 · 3 comments
Open

manual partitioning is unusable (and dangerous) with a larger font #2971

ehaynes99 opened this issue Nov 30, 2024 · 3 comments

Comments

@ehaynes99
Copy link

Which ISO version are you using?

archlinux-2024.11.01-x86_64.iso

The installation log

N/A. This is a UI issue.

describe the problem

Manual partitioning is unusable (and dangerous) with a larger font

archinstall-3.0.1-1

This is on a 1080p display.

  • Prior to running archinstall, use a larger font such as:
setfont solar24x32
  • In archinstall, select "Disk configuration" -> "Partitioning" -> "Manual Partitioning"
  • The disk selection menu is offscreen, and only the current disk properties table is visible. Use the arrow keys up/down and press 'enter' on a drive:
    IMG_20241130_010618
  • On the subsequent screen, only "Press ? for help" at the top is visible.
    IMG_20241130_003147

The user is in a bad state here. ? brings up the general "Archinstall help", which is useless here. ESC doesn't work, ctrl+c doesn't work, q doesn't work. You just have to know that you need to proceed further in to get the option to cancel (that's a usability issue even without the rendering problem TBH).

@Andy-Python-Programmer
Copy link
Contributor

I have the same issue.

@svartkanin
Copy link
Collaborator

I can see how this is not a good behaviour for limited space.
I'm open to any suggestions on how to improve this. Obviously we can enable ESC to abort the operation, but regarding the information cut off it'd be tricky to handle that.

@ehaynes99
Copy link
Author

ESC to abort the operation pretty much universally would be nice, as there are several places where that's not the case. It's pretty universal that that key will cancel something, so at least you can back out of the install script and use another partitioning tool. I'm not a pythonista, but if the menu code is able to know its own dimensions in characters, it could at least detect the case with something like:

import shutil

terminal_size = shutil.get_terminal_size()
width = terminal_size.columns
height = terimal_size.lines

If so, it could at least display an error if everything won't fit.

More ideal would be if it could jump down to display the selected menu item on arrows keys and attempt to right-justify the menu items before wrapping them, that would be better. The wrapping in the table isn't terrible, and someone using a large could reasonably expect some of that, but at minimum, it probably shouldn't allow submitting a menu selection that's outside of the viewable area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants