Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send fixed on a new pipeline/job #128

Open
hsiliev opened this issue Dec 7, 2023 · 3 comments
Open

Do not send fixed on a new pipeline/job #128

hsiliev opened this issue Dec 7, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@hsiliev
Copy link

hsiliev commented Dec 7, 2023

We're using instanced pipelines to handle PRs and the alert resource sends fixed for every job in the new instance of our pipeline

Per documentation:

Fixed is a special alert type that only alerts if the previous build did not succeed.

Can we change fixed to ignore the unknown state (no previous builds) or at least add a param to ignore new jobs?

@arbourd
Copy link
Owner

arbourd commented Mar 5, 2024

Good point! This project is on life support and minimally maintained, would you be willing to submit a PR?

@arbourd arbourd added the help wanted Extra attention is needed label Mar 5, 2024
@arbourd
Copy link
Owner

arbourd commented Apr 4, 2024

So I was looking at the source code and we skip the initial build to see if the pipeline is new: https://github.com/arbourd/concourse-slack-alert-resource/blob/main/out/main.go#L83-L86

But, instanced pipelines are before my time. I assume this value is not 1 as a result. Do you have any indicators from the API you can share with me @hsiliev re: a new instance pipeline?

@hsiliev
Copy link
Author

hsiliev commented Apr 4, 2024

Hey @arbourd,
that's in my todo list, but since it is happening on a side-project it might take a while to get there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants