Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out if we need && operators in DefaultIndexableGetter #1212

Open
aprokop opened this issue Feb 6, 2025 · 0 comments
Open

Figure out if we need && operators in DefaultIndexableGetter #1212

aprokop opened this issue Feb 6, 2025 · 0 comments

Comments

@aprokop
Copy link
Contributor

aprokop commented Feb 6, 2025

The current code is complicated because the const& versions return const&. Which leads to bugs without && versions. It is worth examining whether returning by a value is performant enough to eliminate the && version.

The way to approach it is to create a benchmark that runs indexable getter in a loop. The parameter to tweak would be the size of the Geometry it return. We would want to see how it affects things, and whether there is an inflection point. Would need to run it for the different compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant