Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to build since 6.9.0 with babel-plugin-transform-es2015-modules-commonjs missing #6

Closed
goesbysteve opened this issue Jul 18, 2016 · 12 comments

Comments

@goesbysteve
Copy link

Since moving to 6.9.0 our build is failing with babel-plugin-transform-es2015-modules-commonjs not being found. With the prior 6.6.0 version approach of listing each dependency it works OK.

Any ideas?

Thanks,

Steve.

@goesbysteve
Copy link
Author

goesbysteve commented Jul 18, 2016

npm install babel-plugin-transform-es2015-modules-commonjs

In the root of my project doesn't install the dependencies. If I run npm install in the node_module/babel-preset-es2015-native-modules the dependency is installed and it all works again. I can't work out why this new version wouldn't install it's dependencies

@suchostone
Copy link

Facing same issue. Forced 6.6.0 menawhile..

@goesbysteve
Copy link
Author

I'm doing the same. I've looked at the code of 6.9.0 but can't see why it fails to install. Will look closer when I have the time.

@bartekus
Copy link
Member

Umm the whole point of es2015-native-modules is for them not to have es2015-modules-commonjs.

@goesbysteve
Copy link
Author

goesbysteve commented Jul 21, 2016

Yes but it's failing in the index.js and doesn't install its own dependencies on install so you have to run npm install in this packages folder.

There is definitely something wrong here I feel. Can you try a fresh empty project and only run npm install in the root folder. You'll see what we are seeing then hopefully. Thanks. I'll assist if I can.

@bartekus
Copy link
Member

Indeed, it does seem that it's broken at the moment, and the error 'smart-mirror' is not much of help. I'm investigating.

@goesbysteve
Copy link
Author

Cool. Please let me know if you would like me to help. I can run tests for you on any pull request you create. Thanks for creating the preset.

@bartekus
Copy link
Member

It should be working properly now @stevegibbings, cheers!

@bartekus
Copy link
Member

I'll close this issue now, but feel free to reopen it should the problem persist.

@goesbysteve
Copy link
Author

I'll give it a test today. Thanks for looking at it so quickly.

@bartekus
Copy link
Member

Thank you and no problem.

@goesbysteve
Copy link
Author

Tested 6.9.2 and working great now. Much appreciated

ghost referenced this issue in vercel/hyper Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants