Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command ack #4

Open
ddalacu opened this issue Mar 4, 2021 · 0 comments
Open

Command ack #4

ddalacu opened this issue Mar 4, 2021 · 0 comments

Comments

@ddalacu
Copy link

ddalacu commented Mar 4, 2021

In case that server does not change state when receiving commands it will not send deltas for entities that require command ack and because of that client command buffer will fill and it won't generate new commands which in turn will make server never send deltas and you are stuck :|, i fixed this by alwasys creating deltas for entities with command ack.
So inside RailStateDeltaFactory at line 30 you have
bool shouldReturn = forceAllMutable || includeControllerData && current.HasControllerData || includeImmutableData || removedTick.IsValid;
To fix this you need to add "commandAck.IsValid"
So the whole line would look like
bool shouldReturn = forceAllMutable || includeControllerData && current.HasControllerData || includeImmutableData || removedTick.IsValid || commandAck.IsValid;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant