Skip to content

🚀 Feature: Improving performance of sdk generated for node #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
sahilsekr42 opened this issue Feb 19, 2025 · 6 comments
Closed
2 tasks done

🚀 Feature: Improving performance of sdk generated for node #1035

sahilsekr42 opened this issue Feb 19, 2025 · 6 comments

Comments

@sahilsekr42
Copy link
Contributor

🔖 Feature description

This is in regarding ( appwrite/sdk-for-node#29 ) where some suggestions were given regarding possible improvements to node sdk generation by removing redundant async/await especially the return await pattern wherever possible.

🎤 Pitch

I believe that the node sdk is being generated using templates provided in src/services directory .

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@sahilsekr42
Copy link
Contributor Author

Also as mentioned by @ChiragAgg5k this is open for contribution hence going to raise a PR

@sahilsekr42
Copy link
Contributor Author

Hey @ChiragAgg5k , would be grateful for any reviews or any changes you would like to make and merge PR.

@ChiragAgg5k
Copy link
Member

sure, taking a look

@sahilsekr42
Copy link
Contributor Author

Hello @ChiragAgg5k , hope you're fine..

@sahilsekr42
Copy link
Contributor Author

Since this is done , may I close this @ChiragAgg5k

@ChiragAgg5k
Copy link
Member

marked as done here - #1036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants