Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version in error response #8048

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

The APP_VERSION_STABLE constant should be used for the version in API errors so that developers see a version that makes more sense (such as 1.5.5).

Fixes: #8039

Test Plan

Before:

Screen Shot 2024-04-29 at 3 46 24 PM

After:

Screen Shot 2024-04-29 at 3 48 01 PM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

The APP_VERSION_STABLE constant should be used for the version
in API errors so that developers see a version that makes more
sense (such as 1.5.5).
@stnguyen90 stnguyen90 linked an issue Apr 29, 2024 that may be closed by this pull request
2 tasks
@stnguyen90 stnguyen90 marked this pull request as ready for review April 30, 2024 00:43
@stnguyen90 stnguyen90 self-assigned this May 1, 2024
@christyjacob4 christyjacob4 merged commit 2abd016 into 1.5.x May 7, 2024
21 checks passed
@christyjacob4 christyjacob4 deleted the fix-8039-version-in-response branch May 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Wrong version number in response (Appwrite v1.5.5)
2 participants