Add new country Palestine with its translations #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuelink
changed the title
xuelink
changed the title
stnguyen90
requested changes
Apr 30, 2024
@stnguyen90 You can run this test again, i just fixed and committed for failing test. |
|
@stnguyen90 What do you think that this PR gonna be merged before v1.5.6 ? Best |
stnguyen90
approved these changes
May 14, 2024
xuelink
deleted the
feat-8003-missing-country-for-locale-endpoint-Palestine
branch
This was referenced May 15, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new country to the locale endpoint, providing all the necessary translations.
Fixes #8003
Test Plan
Github Action will test the new country.
Related PRs and Issues
Palestine#8003Checklist