Skip to content

Commit 8f33e18

Browse files
authored
UserValidator: Fix wrong Resource parameter in override validation SAR (#164)
1 parent 7239094 commit 8f33e18

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

webhooks/user_webhook.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ func (v *UserValidator) Handle(ctx context.Context, req admission.Request) admis
3535
if err := sar.AuthorizeResource(ctx, v.client, req.UserInfo, sar.ResourceAttributes{
3636
Verb: "create",
3737
Group: "rbac.appuio.io",
38-
Resource: req.Resource.Group,
38+
Resource: req.Resource.Resource,
3939
Version: req.Resource.Version,
4040
Name: req.Name,
4141
}); err != nil {
42+
log.Info("User not authorized to create other users", "request_user", req.AdmissionRequest.UserInfo, "user", req.Name, "error", err)
4243
return admission.Denied(fmt.Sprintf("user %q is not allowed to create or update %q", req.UserInfo.Username, req.Name))
4344
}
4445
log.Info("User authorized to create other users", "user", req.AdmissionRequest.UserInfo)

0 commit comments

Comments
 (0)