Add table conversion smoke test

Author: glrf

apiserver/organization/table.go

@@ -11,8 +11,12 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/duration"
+	"k8s.io/apiserver/pkg/registry/rest"
 )
 
+var _ rest.TableConvertor = &organizationStorage{}
+
+// ConvertToTable translates the given object to a table for kubectl printing
 func (s *organizationStorage) ConvertToTable(ctx context.Context, obj runtime.Object, tableOptions runtime.Object) (*metav1.Table, error) {
 	var table metav1.Table
 

apiserver/organization/table_test.go

@@ -0,0 +1,72 @@
+package organization
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	orgv1 "github.com/appuio/control-api/apis/organization/v1"
+
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+)
+
+func TestOrganizationStorage_ConvertToTable(t *testing.T) {
+	tests := map[string]struct {
+		obj          runtime.Object
+		tableOptions runtime.Object
+		fail         bool
+		nrRows       int
+	}{
+		"GivenEmptyOrg_ThenSingleRow": {
+			obj:    &orgv1.Organization{},
+			nrRows: 1,
+		},
+		"GivenOrg_ThenSingleRow": {
+			obj: &orgv1.Organization{
+				ObjectMeta: metav1.ObjectMeta{Name: "foo"},
+				Spec: orgv1.OrganizationSpec{
+					DisplayName: "bar",
+				},
+			},
+			nrRows: 1,
+		},
+		"GivenOrgList_ThenMultipleRow": {
+			obj: &orgv1.OrganizationList{
+				Items: []orgv1.Organization{
+					{},
+					{},
+					{},
+				},
+			},
+			nrRows: 3,
+		},
+		"GivenNil_ThenFail": {
+			obj:  nil,
+			fail: true,
+		},
+		"GivenNonOrg_ThenFail": {
+			obj:  &corev1.Pod{},
+			fail: true,
+		},
+		"GivenNonOrgList_ThenFail": {
+			obj:  &corev1.PodList{},
+			fail: true,
+		},
+	}
+	orgStore := &organizationStorage{}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			table, err := orgStore.ConvertToTable(context.TODO(), tc.obj, tc.tableOptions)
+			if tc.fail {
+				require.Error(t, err)
+				return
+			}
+			require.NoError(t, err)
+			assert.Len(t, table.Rows, tc.nrRows)
+		})
+	}
+}