.approval_tests_temp should be configurable

[stefanhh0]

When running approval tests using maven there is always a .approval_tests_temp folder in the base directory created.

It seems to be not configurable since it is defined as constant:
AprovedFileLog#APPROVAL_TEMP_DIRECTORY

It would be nice if that could be made configurable and it would be desirable that this folder should be created in the target folder.

[LarsEckart]

Can you tell us more on how this would be useful for you, that way we can also better understand what we're trying to achieve.

[stefanhh0]

When running mvn test I expect everything to be created under the target folder, so that with mvn clean everything that was created by the tests is gone. However since the .approval_tests_temp is not in the target folder but a sibling of it, it is not removed with mvn clean. Additionally it has to be added to the .gitignore, to prevent putting the contents under source control. All in all this is for sure a minor issue.

[LarsEckart]

oh, mvn clean or avoiding the need for .gitignore, now I understand, sounds very reasonable. We (@isidore @JayBazuzi & me) get back together next week Monday again and will look at this issue again then.