Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom URL player not working #30

Open
apurvis opened this issue Jun 24, 2020 · 5 comments
Open

Custom URL player not working #30

apurvis opened this issue Jun 24, 2020 · 5 comments

Comments

@apurvis
Copy link

apurvis commented Jun 24, 2020

Was having problems getting this to work w/a local MP4 file when I noticed that the "custom" button doesn't even work on the demo site for this package: https://rawgit.com/appleple/react-modal-video/master/test/

Which makes me think the problem is not how I've configured it (which is more or less exactly how the demo site does) and some deeper problem with the package?

@apurvis
Copy link
Author

apurvis commented Jun 24, 2020

cc @ankit307
tested in both chrome and safari

@dwalks12
Copy link

dwalks12 commented Aug 3, 2020

I'm also having an issue running custom video urls but only in iOS Safari. I've attempted using video tags as the children or a custom iframe but am not having any success. I thought it had to do with autoplay or playsinline but that is not the case it seems to be an issue with the video being within a modal.

Does anyone have a solution?

@apurvis
Copy link
Author

apurvis commented Aug 3, 2020

i would advise not using this library at all and just using the HTML5 <video> tag along with the official well supported react-modal; that solved my problem.

@dwalks12
Copy link

dwalks12 commented Aug 3, 2020

I found another solution. Mine was that the video was not optimized for web so i used https://handbrake.fr/ and selected optimize for web and ran it and now it works.

@yvancompaore
Copy link

hi, Do you know how to prevent uploading for our own videos??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants