[6.0][Caching] Add fast swift instance setup for cache replay #73305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cachemeifyoucan
commented
Apr 26, 2024
cachemeifyoucan
commented
- Explanation: add a fast path for swift compiler instance setup when replay cached result.
- Scope: this allows fast replay without expensive input construction from built system
- Original PR: [Caching] Add fast swift instance setup for cache replay #73265
- Issue: rdar://127062609
- Risk: Low. Performance improvement for swift caching.
- Testing: Correct test already covered by existing tests
- Reviewer: @benlangmuir
Add a fast path to create swift CompilerInstance when it is only used to replay output when there is a cache hit. The normal `setup` function is very expensive to call, especially in cache mode to setup inputs, and it needs to be called once per input file from libSwiftScan API due to the current caching granularity. The fast path will only construct the part that is needed for output replay, including the CAS, the output backend and caching diagnostic processor. rdar://127062609 (cherry picked from commit facfe45)
|
@swift-ci please test |
nkcsgexi
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.