Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backtracing] Use stderr by default unless interactive. #66422

Merged
merged 4 commits into from Jun 8, 2023
Merged

[Backtracing] Use stderr by default unless interactive. #66422

merged 4 commits into from Jun 8, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Jun 7, 2023

This means we don't need to specify output-to in CI.

rdar://110371557

@al45tair
[Backtracing] Use stderr by default unless interactive.
3b1db42 
This means we don't need to specify `output-to` in CI.

rdar://110371557
@al45tair
[Backtracing][Tests] Fix tests to redirect output from stderr.
9002daa 
Some of the backtracing tests expected output on stdout.

rdar://110371557
@al45tair
[Backtracing] Also update the Linux crash handler, now it's merged.
67e2fbb 
The Linux crash handler should have the same `output-to` behaviour
as on macOS.

rdar://110371557
@al45tair
[Backtracing][Tests] Fix a test I missed.
a90b05c 
Apparently I missed a redirection in `Crash.swift`.

rdar://110371557
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jun 7, 2023
@al45tair al45tair requested a review from a team as a code owner June 7, 2023 18:52
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

Explanation: Removes the use of output-to in CI, and makes a slightly more intelligent choice about whether to use stdout or stderr instead.
Risk: Low. Only affects backtracing, which is off by default on macOS.
Original PR: #66406
Reviewed by: @MaxDesiatov @mikeash @tbkka
Resolves: rdar://110371557
Tests: I had to fix the tests to work with this, so it's definitely working :-)

@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please test

@al45tair al45tair merged commit a99868f into apple:release/5.9 Jun 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@tomerd tomerd tomerd approved these changes

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@al45tair @MaxDesiatov @tomerd @tbkka