Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backtracing] Use stderr by default unless interactive. #66406

Merged
merged 4 commits into from Jun 7, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Jun 7, 2023

This means we don't need to specify output-to in CI.

rdar://110371557

@al45tair al45tair requested review from mikeash and jckarter June 7, 2023 06:55
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please smoke test

@al45tair al45tair requested a review from tbkka June 7, 2023 06:55
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Member

@swift-ci smoke test

This means we don't need to specify `output-to` in CI.

rdar://110371557
Some of the backtracing tests expected output on stdout.

rdar://110371557
The Linux crash handler should have the same `output-to` behaviour
as on macOS.

rdar://110371557
Apparently I missed a redirection in `Crash.swift`.

rdar://110371557
@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

Rebased.

@al45tair
Copy link
Contributor Author

al45tair commented Jun 7, 2023

@swift-ci Please smoke test

@al45tair al45tair merged commit 861fd2f into apple:main Jun 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants