[Backtracing] Use stderr by default unless interactive. #66406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
al45tair
force-pushed
the
eng/PR-110371557
branch
from
12e0191 to
02725d7
Compare
|
@swift-ci Please smoke test |
MaxDesiatov
approved these changes
Jun 7, 2023
|
@swift-ci Please smoke test |
|
@swift-ci smoke test |
This means we don't need to specify `output-to` in CI. rdar://110371557
Some of the backtracing tests expected output on stdout. rdar://110371557
The Linux crash handler should have the same `output-to` behaviour as on macOS. rdar://110371557
Apparently I missed a redirection in `Crash.swift`. rdar://110371557
al45tair
force-pushed
the
eng/PR-110371557
branch
from
e4a20aa to
646c221
Compare
|
Rebased. |
|
@swift-ci Please smoke test |
mikeash
approved these changes
Jun 7, 2023
tbkka
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't need to specify
output-toin CI.rdar://110371557