Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpreter flags for manifests using pre-release tools-version #6633

Merged
merged 1 commit into from Jul 31, 2023

Conversation

neonichu
Copy link
Member

@neonichu neonichu commented Jun 2, 2023

self.currentToolsVersion >= manifestToolsVersion will always be true when using the 999.0 tools-version, so also accept a higher tools-version if we're in development mode.

@neonichu
Copy link
Member Author

neonichu commented Jun 2, 2023

@swift-ci please smoke test

@neonichu
Copy link
Member Author

neonichu commented Jun 2, 2023

Since this is only relevant during development, we don't need to cherry-pick this into 5.9

Copy link
Member

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this benefit from an added test case?

`self.currentToolsVersion >= manifestToolsVersion` will always be true when using the 999.0 tools-version, so also accept a higher tools-version if we're in development mode.
@neonichu neonichu force-pushed the fix-interpreter-flags-for-999 branch from ee6a379 to b47befa Compare July 31, 2023 19:28
@neonichu
Copy link
Member Author

@swift-ci please smoke test

@neonichu neonichu merged commit 175a886 into main Jul 31, 2023
5 checks passed
@neonichu neonichu deleted the fix-interpreter-flags-for-999 branch July 31, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants