Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Caching] Support pluginCAS in swiftDriver #1422

Conversation

cachemeifyoucan
Copy link
Contributor

Add support for pluginCAS by adopting the new SwiftScan CAS creation APIs. The old CAS creation API is deprecated, and will be removed once all users are updated.

@cachemeifyoucan
Copy link
Contributor Author

Depending on swiftlang/swift#67942

Split out from old #1415 for the pluginCAS part.

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-driver-plugin-cas-support branch from 643448a to b753c34 Compare August 21, 2023 18:25
@artemcm
Copy link
Contributor

artemcm commented Aug 22, 2023

We should update SWIFTSCAN_VERSION here and in swiftlang/swift#67942.

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-driver-plugin-cas-support branch 3 times, most recently from 35d2c80 to 603745b Compare August 23, 2023 18:17
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add tests for this change?

Sources/CSwiftScan/include/swiftscan_header.h Outdated Show resolved Hide resolved
Sources/SwiftDriver/Toolchains/Toolchain.swift Outdated Show resolved Hide resolved
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-driver-plugin-cas-support branch 2 times, most recently from 3c22c00 to 93eb8cc Compare August 28, 2023 16:04
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Add support for pluginCAS by adopting the new SwiftScan CAS creation
APIs. The old CAS creation API is deprecated, and will be removed once
all users are updated.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-swift-driver-plugin-cas-support branch from 93eb8cc to bb0a153 Compare September 7, 2023 20:45
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan cachemeifyoucan merged commit 2e75932 into swiftlang:main Sep 7, 2023
3 checks passed
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-swift-driver-plugin-cas-support branch September 7, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants