Replace Write([]byte()) with io.WriteString() in logger methods (#127)

Also:

* Simplify error handling in semver String method
* Panic if semver String() method fails

---------

Co-authored-by: Dan Chao <[email protected]>

Author: kasugamirai

pkl/logger.go

@@ -49,11 +49,11 @@ type logger struct {
 }
 
 func (s logger) Trace(message string, frameUri string) {
-	_, _ = s.out.Write([]byte(FormatLogMessage("TRACE", message, frameUri)))
+	_, _ = io.WriteString(s.out, FormatLogMessage("TRACE", message, frameUri))
 }
 
 func (s logger) Warn(message string, frameUri string) {
-	_, _ = s.out.Write([]byte(FormatLogMessage("WARN", message, frameUri)))
+	_, _ = io.WriteString(s.out, FormatLogMessage("WARN", message, frameUri))
 }
 
 var _ Logger = (*logger)(nil)

pkl/version.go

@@ -130,7 +130,11 @@ func (s *semver) isLessThan(other *semver) bool {
 
 func (s *semver) String() string {
 	var builder strings.Builder
-	fmt.Fprintf(&builder, "%d.%d.%d", s.major, s.minor, s.patch)
+	_, err := fmt.Fprintf(&builder, "%d.%d.%d", s.major, s.minor, s.patch)
+	if err != nil {
+		// should never happen
+		panic(err.Error())
+	}
 	if s.prerelease != "" {
 		builder.WriteByte('-')
 		builder.WriteString(s.prerelease)