Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text配置修改,含有注释的情况下,撤销修改导致后续存在自动添加重复注释 #5000

Open
3 tasks done
quanbetter opened this issue Oct 20, 2023 · 3 comments
Labels
bug Categorizes issue or PR as related to a bug. help wanted

Comments

@quanbetter
Copy link

quanbetter commented Oct 20, 2023

描述bug
Text配置修改,含有注释的情况下,撤销修改导致后续存在自动添加重复注释

复现

通过如下步骤可以复现:

  1. 通过文本编辑写配置和注释并发布
#注释第一行
key2 = value2
#注释第二行
key3 = value3
image
  1. 文本编辑移除key3配置,提交但不发布
image
  1. 点击撤销按钮
image image 4. 文本编辑追加配置提交 image
  1. 再次文本编辑发现有自动添加
image

期望

简介明了地描述你希望正常情况下应该发生什么
不应该出现文本编辑自动添加一些注释的情况

版本:2.0.1

@dosubot
Copy link

dosubot bot commented Oct 20, 2023

🤖

您好,感谢您的反馈。

根据我在Apollo仓库中找到的相关问题,这个问题可能与Apollo当前的设计有关。在Apollo中,如果配置未发布,是无法撤销的。Apollo的“回滚”功能允许您恢复到之前发布的版本,但这只适用于已经发布的更改。对于未发布的更改,由于它们不是发布版本的一部分,所以无法回滚。

另外,关于文本编辑模式下注释重复出现的问题,我找到了一个类似的问题#4276,这个问题已经在#4279的pull request中被修复了。这个修复是通过检查item.isDeleted来判断项目是否被删除。

但是,我注意到您使用的Apollo版本是2.0.1,而这个修复是在2.1.0版本中才有的。因此,我建议您升级到最新的Apollo版本,看看这个问题是否还存在。

如果问题仍然存在,那么可能需要更深入地研究这个问题。如果可能的话,您能提供更多关于这个问题的信息吗?例如,这个问题是否在所有环境中都会出现,还是只在特定的环境中出现?这将有助于我们更好地理解和解决这个问题。

再次感谢您的反馈,期待您的回复。

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@quanbetter
Copy link
Author

🤖

您好,感谢您的反馈。

根据我在Apollo仓库中找到的相关问题,这个问题可能与Apollo当前的设计有关。在Apollo中,如果配置未发布,是无法撤销的。Apollo的“回滚”功能允许您恢复到之前发布的版本,但这只适用于已经发布的更改。对于未发布的更改,由于它们不是发布版本的一部分,所以无法回滚。

另外,关于文本编辑模式下注释重复出现的问题,我找到了一个类似的问题#4276,这个问题已经在#4279的pull request中被修复了。这个修复是通过检查item.isDeleted来判断项目是否被删除。

但是,我注意到您使用的Apollo版本是2.0.1,而这个修复是在2.1.0版本中才有的。因此,我建议您升级到最新的Apollo版本,看看这个问题是否还存在。

如果问题仍然存在,那么可能需要更深入地研究这个问题。如果可能的话,您能提供更多关于这个问题的信息吗?例如,这个问题是否在所有环境中都会出现,还是只在特定的环境中出现?这将有助于我们更好地理解和解决这个问题。

再次感谢您的反馈,期待您的回复。

Sources

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.
官网提供的例子http://81.68.181.139/ 是2.1.0吗,如果是,那2.1.0版本还是存在我上面说的场景

@dosubot
Copy link

dosubot bot commented Oct 20, 2023

🤖

Hello,

Thank you for providing the detailed steps to reproduce the issue. Based on the information you've provided, it seems like you're encountering a known issue that was previously reported in the Apollo repository. The issue, titled 文本模式注释掉一些变量之后,不进行发布,重新点击文本模式进行修改,会重复出现注释掉的数据, describes a similar problem where comments are duplicated when modifications are undone.

This issue was resolved by a pull request: use item.isDeleted to check whether the item is deleted which was merged on March 27, 2022. The fix involves checking whether an item is deleted before proceeding with the modification, which prevents the duplication of comments.

As for your question about whether this issue occurs in all environments or only in specific ones, the issue report and subsequent fix do not specify any environment-specific conditions. Therefore, it's likely that this issue could occur in any environment where the Apollo 2.0.1 version is being used.

Given that the fix was merged after the release of Apollo 2.0.1, upgrading to the latest version, Apollo 2.1.0 Release, should resolve the issue you're experiencing. I would recommend proceeding with the upgrade and verifying if the issue persists.

I hope this helps! If you have any other questions or need further clarification, please don't hesitate to ask.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@nobodyiam nobodyiam added bug Categorizes issue or PR as related to a bug. help wanted labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. help wanted
Projects
None yet
Development

No branches or pull requests

2 participants