You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a big issue here when using @apla/clickhouse, because in case of error the output stream will emit the finish event before the error event, so the promise will resolve (ie. will not reject).
So basically using @apla/clickhouse with pipeline will cause errors to fail silently!
To fix this issue the stream created by @apla/clickhouse query function should finish after having errored I guess.
The text was updated successfully, but these errors were encountered:
paeolo
changed the title
node clickhouse fails silently when used with "pipeline".
node-clickhouse fails silently when used with "pipeline".
May 5, 2021
It's a common thing when dealing with streams to wrap them with a pipeline like so:
There is a big issue here when using
@apla/clickhouse
, because in case of error the output stream will emit thefinish
event before theerror
event, so the promise will resolve (ie. will not reject).So basically using
@apla/clickhouse
withpipeline
will cause errors to fail silently!To fix this issue the stream created by
@apla/clickhouse
query function should finish after having errored I guess.The text was updated successfully, but these errors were encountered: