Cannot use JSONEachRow format

[vibl]

I was trying to sending an INSERT query with a JSONEachRow format and any of my attempts failed.

While debugging I found two problems:

The line

node-clickhouse/src/clickhouse.js

Line 272 in 5ac5a8f

if (!options.omitFormat && formatMatch) {

overrides the options.format = "JSONEachRow" I have explicitly set. Is that on purpose? If so, why?

The regexp

node-clickhouse/src/clickhouse.js

Line 269 in 5ac5a8f

var formatRegexp = /FORMAT\s+(BlockTabSeparated|CSV|CSVWithNames|JSON|JSONCompact|JSONEachRow|Native|Null|Pretty|PrettyCompact|PrettyCompactMonoBlock|PrettyNoEscapes|PrettyCompactNoEscapes|PrettySpaceNoEscapes|PrettySpace|RowBinary|TabSeparated|TabSeparatedRaw|TabSeparatedWithNames|TabSeparatedWithNamesAndTypes|TSKV|Values|Vertical|XML)/i;

should have a \b on each side of the parentheses group, otherwise e.g. JSON is matched instead of JSONEachRow.

So:

 var formatRegexp = /FORMAT\s+\b(BlockTabSeparated|CSV|CSVWithNames|JSON|JSONCompact|JSONEachRow|Native|Null|Pretty|PrettyCompact|PrettyCompactMonoBlock|PrettyNoEscapes|PrettyCompactNoEscapes|PrettySpaceNoEscapes|PrettySpace|RowBinary|TabSeparated|TabSeparatedRaw|TabSeparatedWithNames|TabSeparatedWithNamesAndTypes|TSKV|Values|Vertical|XML)\b/i; 

So options.format ended up being set as JSON whatever I was doing.

[vincenzon]

I hit this issue as well. In case others do a fix is to explicitly set the format option:

const clickhouseStream = clickhouse.query(
      `insert into some_table`,
      { format: "JSONEachRow" }
    );

instead of:

const clickhouseStream = clickhouse.query(
      `insert into some_table format JSONEachRow`,
    );