Update dependency @api3/eslint-plugin-commons to v2 (#351)

* Update dependency @api3/eslint-plugin-commons to v2

* Remove rules that have been excluded

* Fix lint by importing constant

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Derek Croote <[email protected]>

Author: renovate[bot]

.eslintrc.js

@@ -17,22 +17,4 @@ module.exports = {
   },
   extends: ['plugin:@api3/eslint-plugin-commons/universal', 'plugin:@api3/eslint-plugin-commons/jest'],
   plugins: ['@typescript-eslint', 'import', 'jest'],
-  rules: {
-    'unicorn/no-process-exit': 'off',
-    'unicorn/prefer-top-level-await': 'off',
-
-    // Typescript
-    '@typescript-eslint/consistent-return': 'off', // Does not play with no useless undefined when function return type is "T | undefined" and does not have a fixer.
-    '@typescript-eslint/max-params': 'off',
-    '@typescript-eslint/no-dynamic-delete': 'off',
-    '@typescript-eslint/no-var-requires': 'off',
-    '@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
-
-    // Lodash
-    'lodash/prefer-immutable-method': 'off',
-    'lodash/prop-shorthand': 'off',
-
-    // Jest
-    'jest/no-hooks': 'off',
-  },
 };

local-test-configuration/scripts/initialize-chain.ts

@@ -19,6 +19,7 @@ import dotenv from 'dotenv';
 import { type JsonRpcProvider, NonceManager, ethers } from 'ethers';
 import { zip } from 'lodash';
 
+import { HUNDRED_PERCENT } from '../../src/constants';
 import { getGasPrice } from '../../src/gas-price';
 import { deriveSponsorWallet, encodeDapiName } from '../../src/utils';
 
@@ -54,8 +55,7 @@ export const deriveRole = (adminRole: string, roleDescription: string) => {
 };
 
 function encodeUpdateParameters() {
-  const HUNDRED_PERCENT = 1e8;
-  const deviationThresholdInPercentage = HUNDRED_PERCENT / 100; // 1%
+  const deviationThresholdInPercentage = HUNDRED_PERCENT / 100n; // 1%
   const deviationReference = 0;
   const heartbeatInterval = 86_400; // 24 hrs
   const updateParameters = ethers.AbiCoder.defaultAbiCoder().encode(

package.json

@@ -39,7 +39,7 @@
     "@api3/chains": "^8.1.1",
     "@api3/commons": "^0.10.0",
     "@api3/contracts": "5.1.0",
-    "@api3/eslint-plugin-commons": "^1.0.1",
+    "@api3/eslint-plugin-commons": "^2.0.0",
     "@api3/promise-utils": "^0.4.0",
     "dotenv": "^16.4.5",
     "ethers": "^6.13.1",