Skip to content

Add default .upignore creation to project setup #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add default .upignore creation to project setup #747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf4bb6
add default .upignore creation to project setup. Closes #728
hhsnopek Jan 7, 2019
1303216
remove unnecessary term lines
hhsnopek Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions internal/setup/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func Create() error {

println()

// confirm
// confirm create new project
var ok bool
err := survey.AskOne(&survey.Confirm{
Message: fmt.Sprintf("No up.json found, create a new project?"),
Expand Down Expand Up @@ -106,7 +106,30 @@ func Create() error {
}

b, _ := json.MarshalIndent(c, "", " ")
return ioutil.WriteFile("up.json", b, 0644)
err = ioutil.WriteFile("up.json", b, 0644)
if err != nil {
return err
}

// confirm create .upignore
term.MoveUp(1)
term.ClearLine()
Copy link
Contributor Author

@hhsnopek hhsnopek Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? (L115-L116)

term.MoveUp(1)
term.ClearLine()

Copy link
Contributor Author

@hhsnopek hhsnopek Jan 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in 1303216, which fixes the codeclimate tests 😂

err = survey.AskOne(&survey.Confirm{
Message: fmt.Sprintf("Would you like to add an .upignore?"),
Default: true,
}, &ok, nil)

if err != nil {
return nil
}

if !ok {
return errors.New("aborted")
}

defaultIgnore := ".*\n"
b = []byte(defaultIgnore)
return ioutil.WriteFile(".upignore", b, 0644)
}

// defaultName returns the default app name.
Expand Down