TIKA-4397: use isBlank()

Author: THausherr

tika-core/src/main/java/org/apache/tika/pipes/fetcher/FetcherManager.java

@@ -48,7 +48,7 @@ public static FetcherManager load(Path p) throws IOException, TikaConfigExceptio
     public FetcherManager(List<Fetcher> fetchers) throws TikaConfigException {
         for (Fetcher fetcher : fetchers) {
             String name = fetcher.getName();
-            if (name == null || name.trim().isEmpty()) {
+            if (name == null || name.isBlank()) {
                 throw new TikaConfigException("fetcher name must not be blank");
             }
             if (fetcherMap.containsKey(fetcher.getName())) {

tika-core/src/main/java/org/apache/tika/pipes/fetcher/fs/FileSystemFetcher.java

@@ -155,7 +155,7 @@ public void initialize(Map<String, Param> params) throws TikaConfigException {
     @Override
     public void checkInitialization(InitializableProblemHandler problemHandler)
             throws TikaConfigException {
-        if (basePath == null || basePath.toString().trim().isEmpty()) {
+        if (basePath == null || basePath.toString().isBlank()) {
             LOG.warn("'basePath' has not been set. " +
                     "This means that client code or clients can read from any file that this " +
                     "process has permissions to read. If you are running tika-server, make " +

tika-parsers/tika-parsers-extended/tika-parser-scientific-module/src/main/java/org/apache/tika/parser/envi/EnviHeaderParser.java

@@ -157,7 +157,7 @@ private String[] convertMapInfoValuesToLatLngAndSetMetadata(String[] mapInfoValu
         double pixelEasting = Double.parseDouble(mapInfoValues[3].trim());
         double pixelNorthing = Double.parseDouble(mapInfoValues[4].trim());
         int zone = 0;
-        if (!mapInfoValues[7].trim().isEmpty()) {
+        if (!mapInfoValues[7].isBlank()) {
             zone = Integer.parseInt(mapInfoValues[7].trim());
         }
 

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-html-module/src/main/java/org/apache/tika/parser/html/HtmlHandler.java

@@ -378,7 +378,7 @@ private void handleDataURIScheme(String string) throws SAXException {
     private void writeScript() throws SAXException {
         //don't write an attached macro if there is no content
         //we may want to revisit this behavior
-        if (script.toString().trim().isEmpty()) {
+        if (script.toString().isBlank()) {
             return;
         }
         //do anything with attrs?

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/xps/XPSPageContentHandler.java

@@ -415,7 +415,7 @@ private static List<GlyphRun> splitRow(List<GlyphRun> row) {
     private static void sortRow(List<GlyphRun> row) {
         boolean allRTL = true;
         for (GlyphRun run : row)  {
-            if (run.unicodeString.trim().isEmpty()) {
+            if (run.unicodeString.isBlank()) {
                 // ignore whitespace for all RTL check
                 continue;
             }

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/parser/pdf/XFAExtractor.java

@@ -121,7 +121,7 @@ void extract(InputStream xfaIs, XHTMLContentHandler xhtml, Metadata m, ParseCont
             String fieldName = e.getKey();
             XFAField field = e.getValue();
             String displayFieldName =
-                    (field.toolTip == null || field.toolTip.trim().isEmpty()) ? fieldName :
+                    (field.toolTip == null || field.toolTip.isBlank()) ? fieldName :
                             field.toolTip;
             String[] fieldValues = pdfObjRToValues.getValues(fieldName);
             if (fieldValues.length == 0) {