TIKA-4397: use isEmpty()

Author: THausherr

tika-app/src/main/java/org/apache/tika/cli/TikaCLI.java

@@ -446,7 +446,7 @@ public void process(String arg) throws Exception {
             String dirPath = arg.substring("--extract-dir=".length());
             //if the user accidentally doesn't include
             //a directory, set the directory to the cwd
-            if (dirPath.length() == 0) {
+            if (dirPath.isEmpty()) {
                 dirPath = ".";
             }
             extractDir = new File(dirPath);

tika-batch/src/main/java/org/apache/tika/batch/builders/CommandLineParserBuilder.java

@@ -88,7 +88,7 @@ private Option buildOption(Node optionNode) {
         String longOpt = getString(map, "longOpt", "");
         boolean isRequired = getBoolean(map, "required", false);
         boolean hasArg = getBoolean(map, "hasArg", false);
-        if (opt.trim().length() == 0 || description.trim().length() == 0) {
+        if (opt.trim().isEmpty() || description.trim().isEmpty()) {
             throw new IllegalArgumentException("Must specify at least option and description");
         }
         Option option = new Option(opt, description);

tika-batch/src/main/java/org/apache/tika/batch/fs/builders/FSCrawlerBuilder.java

@@ -118,7 +118,7 @@ public FileResourceCrawler build(Node node, Map<String, String> runtimeAttribute
     }
 
     private FSDirectoryCrawler.CRAWL_ORDER getCrawlOrder(String s) {
-        if (s == null || s.trim().length() == 0 || s.equals("os")) {
+        if (s == null || s.trim().isEmpty() || s.equals("os")) {
             return FSDirectoryCrawler.CRAWL_ORDER.OS_ORDER;
         } else if (s.toLowerCase(Locale.ROOT).contains("rand")) {
             return FSDirectoryCrawler.CRAWL_ORDER.RANDOM;

tika-batch/src/main/java/org/apache/tika/util/PropsUtil.java

@@ -35,7 +35,7 @@ public class PropsUtil {
      * @return parsed value
      */
     public static Boolean getBoolean(String v, Boolean defaultMissing) {
-        if (v == null || v.length() == 0) {
+        if (v == null || v.isEmpty()) {
             return defaultMissing;
         }
         if (v.toLowerCase(Locale.ROOT).equals("true")) {
@@ -55,7 +55,7 @@ public static Boolean getBoolean(String v, Boolean defaultMissing) {
      * @return parsed value
      */
     public static Integer getInt(String v, Integer defaultMissing) {
-        if (v == null || v.length() == 0) {
+        if (v == null || v.isEmpty()) {
             return defaultMissing;
         }
         try {
@@ -74,7 +74,7 @@ public static Integer getInt(String v, Integer defaultMissing) {
      * @return parsed value
      */
     public static Long getLong(String v, Long defaultMissing) {
-        if (v == null || v.length() == 0) {
+        if (v == null || v.isEmpty()) {
             return defaultMissing;
         }
         try {
@@ -96,7 +96,7 @@ public static Long getLong(String v, Long defaultMissing) {
      */
     @Deprecated
     public static File getFile(String v, File defaultMissing) {
-        if (v == null || v.length() == 0) {
+        if (v == null || v.isEmpty()) {
             return defaultMissing;
         }
         //trim initial and final " if they exist
@@ -133,7 +133,7 @@ public static String getString(String v, String defaultMissing) {
      * @see #getPath(String, Path)
      */
     public static Path getPath(String v, Path defaultMissing) {
-        if (v == null || v.length() == 0) {
+        if (v == null || v.isEmpty()) {
             return defaultMissing;
         }
         //trim initial and final " if they exist

tika-batch/src/test/java/org/apache/tika/batch/fs/FSBatchTestBase.java

@@ -172,7 +172,7 @@ public String[] getDefaultCommandLineArgsArr(String inputSubDir, Path outputDir,
 
     public Path getInputRoot(String subdir) throws Exception {
         String path =
-                (subdir == null || subdir.length() == 0) ? "/test-input" : "/test-input/" + subdir;
+                (subdir == null || subdir.isEmpty()) ? "/test-input" : "/test-input/" + subdir;
         return Paths.get(getResourceAsUri(path));
     }
 

tika-core/src/main/java/org/apache/tika/io/FilenameUtils.java

@@ -96,7 +96,7 @@ public static String normalize(final String name) {
      */
     public static String getName(final String path) {
 
-        if (path == null || path.length() == 0) {
+        if (path == null || path.isEmpty()) {
             return StringUtils.EMPTY;
         }
         int unix = path.lastIndexOf("/");

tika-core/src/main/java/org/apache/tika/mime/MediaType.java

@@ -294,7 +294,7 @@ private static boolean isSimpleName(String name) {
     }
 
     private static Map<String, String> parseParameters(String string) {
-        if (string.length() == 0) {
+        if (string.isEmpty()) {
             return Collections.emptyMap();
         }
 

tika-core/src/main/java/org/apache/tika/pipes/fetcher/FetcherManager.java

@@ -48,7 +48,7 @@ public static FetcherManager load(Path p) throws IOException, TikaConfigExceptio
     public FetcherManager(List<Fetcher> fetchers) throws TikaConfigException {
         for (Fetcher fetcher : fetchers) {
             String name = fetcher.getName();
-            if (name == null || name.trim().length() == 0) {
+            if (name == null || name.trim().isEmpty()) {
                 throw new TikaConfigException("fetcher name must not be blank");
             }
             if (fetcherMap.containsKey(fetcher.getName())) {

tika-core/src/main/java/org/apache/tika/pipes/fetcher/fs/FileSystemFetcher.java

@@ -147,7 +147,7 @@ public void initialize(Map<String, Param> params) throws TikaConfigException {
     @Override
     public void checkInitialization(InitializableProblemHandler problemHandler)
             throws TikaConfigException {
-        if (basePath == null || basePath.toString().trim().length() == 0) {
+        if (basePath == null || basePath.toString().trim().isEmpty()) {
             LOG.warn("'basePath' has not been set. " +
                     "This means that client code or clients can read from any file that this " +
                     "process has permissions to read. If you are running tika-server, make " +

tika-core/src/main/java/org/apache/tika/sax/ToXMLContentHandler.java

@@ -250,7 +250,7 @@ public String getPrefix(String uri) throws SAXException {
                 return prefix;
             } else if (parent != null) {
                 return parent.getPrefix(uri);
-            } else if (uri == null || uri.length() == 0) {
+            } else if (uri == null || uri.isEmpty()) {
                 return "";
             } else {
                 throw new SAXException("Namespace " + uri + " not declared");