[SPARK-54405][SQL][Metric View] CREATE command and SELECT query resolution #53158
+963
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add METRICS keyword to lexer - Add dollar-quoted string support for YAML definitions - Add createMetricView production rule - Add METRIC_VIEW catalog table type - Implement CreateMetricViewCommand: - Parse YAML definition - Build MetricViewPlaceholder logical node - Validate and analyze metric view - Add MetricViewPlaceholder logical node with tree patterns - Update ViewHelper to support metric view creation - Add basic test suite for metric views - Add MetricViewPlanner utility: - planRead() to parse metric view for SELECT queries - planWrite() refactored from metricViewCommands - parseYAML() shared parsing logic - Add ResolveMetricView analyzer rule: - Transform MetricViewPlaceholder into aggregation queries - Parse dimensions and measures from schema metadata - Build Project with dimensions and Aggregate with measures - Handle measure references in aggregates - Update SessionCatalog to parse metric view definitions on read - Update EliminateView to handle ResolvedMetricView nodes - Refactor CreateMetricViewCommand to use MetricViewPlanner - Update ViewHelper to set METRIC_VIEW table type correctly - Add ResolveMetricView to analyzer rule chain - Update test suite with query tests update test test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR implements the command to create metric views and the analysis rule to resolve a metric view query:
WITH METRICwhen creating a viewNOTE: This PR depends on #53146
Why are the changes needed?
SPIP: Metrics & semantic modeling in Spark
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No