[SPARK-46166][PS] Implementation of pandas.DataFrame.any with axis=1 #53096
+84
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is=1 Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
holdenk
reviewed
Nov 18, 2025
Contributor
holdenk
left a comment
holdenk
left a comment
There was a problem hiding this comment.
Thanks for working on this! Quick question regarding the validate change :) CC @HyukjinKwon who mentioned being interested in reviewing this when we chatted :)
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Nov 18, 2025
allisonwang-db
approved these changes
Nov 18, 2025
Signed-off-by: Devin Petersohn <[email protected]>
Author
|
I believe that all comments so far have been addressed. Any other changes needed to get this across the finish line? |
Member
|
LGTM let me leave it to @holdenk to merge |
Contributor
|
LGTM I'll merge it this week (currently on a work trip) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
New parameter
axis=1support forpandas.DataFrame.anyWhy are the changes needed?
To introduce
axis=1Does this PR introduce any user-facing change?
Yes,
anywill now supportaxis=1.How was this patch tested?
Locally, new tests
Was this patch authored or co-authored using generative AI tooling?
No