Skip to content

Commit 6850ebf

Browse files
author
Karuppayya Rajendran
committed
Address review comments: Remove unused code, fix test to write csv
1 parent 6cef7bd commit 6850ebf

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import org.apache.spark.internal.config.{SPARK_DRIVER_PREFIX, SPARK_EXECUTOR_PRE
3030
import org.apache.spark.internal.config.Tests.IS_TESTING
3131
import org.apache.spark.sql.classic.SparkSession
3232
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanExec
33-
import org.apache.spark.sql.execution.command.{DataWritingCommandExec, ExecutedCommandExec}
33+
import org.apache.spark.sql.execution.command.DataWritingCommandExec
3434
import org.apache.spark.sql.execution.datasources.v2.V2CommandExec
3535
import org.apache.spark.sql.execution.exchange.ShuffleExchangeLike
3636
import org.apache.spark.sql.execution.ui.{SparkListenerSQLExecutionEnd, SparkListenerSQLExecutionStart}
@@ -194,9 +194,6 @@ object SQLExecution extends Logging {
194194
command.children.flatMap(extractShuffleIds)
195195
case dataWritingCommand: DataWritingCommandExec =>
196196
extractShuffleIds(dataWritingCommand.child)
197-
case _: ExecutedCommandExec =>
198-
// TODO: Discuss
199-
Seq()
200197
case plan =>
201198
extractShuffleIds(plan)
202199
}

sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ class QueryExecutionSuite extends SharedSparkSession {
351351
val plan = spark.range(100).repartition(10).logicalPlan
352352
val df = Dataset.ofRows(spark, plan)
353353
// V1 API write
354-
df.write.format("parquet").mode(SaveMode.Overwrite).save(dir.getCanonicalPath)
354+
df.write.format("csv").mode(SaveMode.Overwrite).save(dir.getCanonicalPath)
355355

356356
val blockManager = spark.sparkContext.env.blockManager
357357
assert(blockManager.migratableResolver.getStoredShuffles().isEmpty)

0 commit comments

Comments
 (0)