not every ingress controller is nginx

[msporleder]

solr-operator/controllers/util/solr_util.go

Lines 1088 to 1104 in 630efa0

	if solrNodesRequireTLS {
	if annotations == nil {
	annotations = make(map[string]string, 1)
	}
	_, ok := annotations["nginx.ingress.kubernetes.io/backend-protocol"]
	if !ok {
	annotations["nginx.ingress.kubernetes.io/backend-protocol"] = "HTTPS"
	}
	} else {
	if annotations == nil {
	annotations = make(map[string]string, 1)
	}
	_, ok := annotations["nginx.ingress.kubernetes.io/backend-protocol"]
	if !ok {
	annotations["nginx.ingress.kubernetes.io/backend-protocol"] = "HTTP"
	}
	}

Although this is pretty harmless as noise I'm not sure why this assumption was hard-coded in.

Can you consider adding if customOptions.IngressClassName == "nginx" or similar?

[gerlowskija]

Agreed - it's likely not causing any harm, but it'd make sense to have this annotation be conditional on the actual Ingress controller in use.

If you're interested in opening a PR @msporleder, I'd be happy to review!