Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SolrPrometheusExporter should detect whether to use a basicAuth secret #654

Open
HoustonPutman opened this issue Nov 10, 2023 · 2 comments
Labels
metrics security TLS or Auth for Solr
Milestone

Comments

@HoustonPutman
Copy link
Contributor

Currently in the PrometheusExporter spec, you must specify a basicAuthSecret if you have BasicAuth enabled on a solrCloud.

The operator should be able to detect if the SolrCloud is setup to use BasicAuth, and figure out the secret it is using if the use does not provide an explicit basicAuthSecret. This should work very similarly to how the zkConnection info and solrImage are also taken from the SolrCloud reference, if none are provided.

Docs:
https://apache.github.io/solr-operator/docs/solr-prometheus-exporter/#prometheus-exporter-with-basic-auth

@HoustonPutman HoustonPutman added metrics security TLS or Auth for Solr labels Nov 10, 2023
@HoustonPutman HoustonPutman added this to the main (v0.9.0) milestone Nov 10, 2023
@radu-gheorghe
Copy link
Contributor

I've fiddled with this enough to think that I understand the use-case. It sounds like we have two paths:

  1. The user bootstapped basic auth. In this case, we need to point the exporter to the default auth secret (-solrcloud-basic-auth).
  2. The user provided their own security.json and auth secret. In which case that secret will be in the SoldCloud object definition, so we should simply get it from there and re-use it in the exporter.

Am I on the right path?

@HoustonPutman
Copy link
Contributor Author

Sorry, I missed this. But yes, you are on the right path!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics security TLS or Auth for Solr
Projects
None yet
Development

No branches or pull requests

2 participants